Improve scene view #659
Merged
Improve scene view #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #659 +/- ##
=========================================
Coverage ? 91.74%
=========================================
Files ? 392
Lines ? 4895
Branches ? 0
=========================================
Hits ? 4491
Misses ? 404
Partials ? 0
Continue to review full report at Codecov.
|
R6n0
pushed a commit
to R6n0/Gladys
that referenced
this pull request
Dec 2, 2020
* Add light.turn-off action server-side * Add turn off the lights box * Remove "new" from new action/trigger button * Create a SelectDeviceFeature components which can be re-used * Add DeviceGetValue and OnlyContinueIf action in scenes * Fix condition variable names * Upgrade Preact * Only continue if with multiple conditions working * Add condition / remove condition * Fix linting * Add server-side code for continue only if and device.get-value * Add tests to new actions * Add error message, name cannot be 'new' * Add translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm teston both front/server)npm run eslinton both front/server)npm run prettieron both front/server)front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!