Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] - Zwave: add multi-instance devices support, comClass and Units mapping, modify device view, #759

Closed
wants to merge 8 commits into from

Conversation

link39
Copy link

@link39 link39 commented Apr 28, 2020

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@link39 link39 changed the title Zwave: add comClass and Units mapping, modify device view Zwave: add multi-instance devices support, comClass and Units mapping, modify device view, Apr 28, 2020
@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #759 into master will decrease coverage by 0.51%.
The diff coverage is 68.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
- Coverage   92.24%   91.72%   -0.52%     
==========================================
  Files         419      419              
  Lines        5417     5428      +11     
==========================================
- Hits         4997     4979      -18     
- Misses        420      449      +29     
Flag Coverage Δ
#server 91.72% <68.75%> (-0.52%) ⬇️
Impacted Files Coverage Δ
server/services/zwave/lib/constants.js 100.00% <ø> (ø)
server/services/zwave/lib/utils/getCategory.js 11.11% <ø> (-88.89%) ⬇️
server/services/zwave/lib/utils/getUnit.js 14.28% <0.00%> (-48.22%) ⬇️
server/utils/constants.js 100.00% <ø> (ø)
...er/services/zwave/lib/events/zwave.valueRemoved.js 80.00% <66.66%> (-20.00%) ⬇️
...rver/services/zwave/lib/commands/zwave.getNodes.js 85.71% <84.21%> (-10.29%) ⬇️
...rver/services/zwave/lib/events/zwave.valueAdded.js 100.00% <100.00%> (ø)
...er/services/zwave/lib/events/zwave.valueChanged.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8196d4f...579a213. Read the comment docs.

@link39 link39 changed the title Zwave: add multi-instance devices support, comClass and Units mapping, modify device view, [WIP] - Zwave: add multi-instance devices support, comClass and Units mapping, modify device view, May 8, 2020
@Pierre-Gilles
Copy link
Contributor

Hello !

A part le code coverage, que manque il dans cette PR pour qu'elle soit mergée ?

@link39
Copy link
Author

link39 commented Sep 10, 2020

Hello,

Uniquement le code coverage. Le code est fonctionnel.

@Pierre-Gilles
Copy link
Contributor

Many thanks for this PR! 👏

It's now merged in #893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants