-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@Link39 Z-Wave PR with fixes and tests #893
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #893 +/- ##
==========================================
+ Coverage 93.53% 93.58% +0.04%
==========================================
Files 461 461
Lines 6112 6123 +11
==========================================
+ Hits 5717 5730 +13
+ Misses 395 393 -2
Continue to review full report at Codecov.
|
7 tasks
R6n0
pushed a commit
to R6n0/Gladys
that referenced
this pull request
Dec 2, 2020
…g, modify device view (GladysAssistant#893) * Add zwave mapping : Volt/Watt/Ampere/Kwh * Zwave : New devices and multilevel scroll * Fix Roller shutter ZMNHCDx category and Id * fix ZMNHCDx type and category * add Lux units * Display all node in Setup page * Sort nodes in setup page * Run prettier * Fix bug in zwave Device page when house list is not fully loaded * Add missing translations * Add more tests to z-wave * Add test to zwave.getUnit Co-authored-by: Thibaut Courvoisier <link39@live.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.json
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!