Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation + i18n checker #771

Merged
merged 29 commits into from
May 5, 2020

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented May 5, 2020

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #771 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #771   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         419      419           
  Lines        5422     5422           
=======================================
  Hits         5009     5009           
  Misses        413      413           
Flag Coverage Δ
#server 92.38% <ø> (ø)
Impacted Files Coverage Δ
server/utils/constants.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c3666...1d618d9. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit 73e93a5 into master May 5, 2020
@Pierre-Gilles Pierre-Gilles deleted the atrovato-compare-translation-files branch May 5, 2020 14:51
NickDub-old pushed a commit to NickDub/Gladys that referenced this pull request Aug 7, 2020
…tant#771)

* i18n checker

* i18n: replace hard coded by keys

* i18n: add FR translations

* i18n: integration comparator

* i18n: update fr translation

* i18n: localize dates

* i18n: localize scenes

* i18n: clean not used messages

* i18n: dashboard select room

* i18n: fix merge conflicts

* i18n: remove backend files

* i18n: fix merge misses

* i18n: merge CalDAV integration

* i18n: merge new gateway page

* i18n: merge G.P backup

* Make app work in french too

* Fix some translations in FR

* Add default language from browser at signup

* Multiple translation fixes

* Add calendar translations

* Add messages in FR for the brain

* Improve translations

* Fix gateway translations

* Make integration page work in FR

* Fix french translations

* Fix translations

* Fix session translation

* Load language from local storage, then navigator if not in localstorage

Co-authored-by: atrovato <1839717+atrovato@users.noreply.github.com>
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
…tant#771)

* i18n checker

* i18n: replace hard coded by keys

* i18n: add FR translations

* i18n: integration comparator

* i18n: update fr translation

* i18n: localize dates

* i18n: localize scenes

* i18n: clean not used messages

* i18n: dashboard select room

* i18n: fix merge conflicts

* i18n: remove backend files

* i18n: fix merge misses

* i18n: merge CalDAV integration

* i18n: merge new gateway page

* i18n: merge G.P backup

* Make app work in french too

* Fix some translations in FR

* Add default language from browser at signup

* Multiple translation fixes

* Add calendar translations

* Add messages in FR for the brain

* Improve translations

* Fix gateway translations

* Make integration page work in FR

* Fix french translations

* Fix translations

* Fix session translation

* Load language from local storage, then navigator if not in localstorage

Co-authored-by: atrovato <1839717+atrovato@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants