-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
French translation + i18n checker #771
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #771 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 419 419
Lines 5422 5422
=======================================
Hits 5009 5009
Misses 413 413
Continue to review full report at Codecov.
|
7 tasks
NickDub-old
pushed a commit
to NickDub/Gladys
that referenced
this pull request
Aug 7, 2020
…tant#771) * i18n checker * i18n: replace hard coded by keys * i18n: add FR translations * i18n: integration comparator * i18n: update fr translation * i18n: localize dates * i18n: localize scenes * i18n: clean not used messages * i18n: dashboard select room * i18n: fix merge conflicts * i18n: remove backend files * i18n: fix merge misses * i18n: merge CalDAV integration * i18n: merge new gateway page * i18n: merge G.P backup * Make app work in french too * Fix some translations in FR * Add default language from browser at signup * Multiple translation fixes * Add calendar translations * Add messages in FR for the brain * Improve translations * Fix gateway translations * Make integration page work in FR * Fix french translations * Fix translations * Fix session translation * Load language from local storage, then navigator if not in localstorage Co-authored-by: atrovato <1839717+atrovato@users.noreply.github.com>
R6n0
pushed a commit
to R6n0/Gladys
that referenced
this pull request
Dec 2, 2020
…tant#771) * i18n checker * i18n: replace hard coded by keys * i18n: add FR translations * i18n: integration comparator * i18n: update fr translation * i18n: localize dates * i18n: localize scenes * i18n: clean not used messages * i18n: dashboard select room * i18n: fix merge conflicts * i18n: remove backend files * i18n: fix merge misses * i18n: merge CalDAV integration * i18n: merge new gateway page * i18n: merge G.P backup * Make app work in french too * Fix some translations in FR * Add default language from browser at signup * Multiple translation fixes * Add calendar translations * Add messages in FR for the brain * Improve translations * Fix gateway translations * Make integration page work in FR * Fix french translations * Fix translations * Fix session translation * Load language from local storage, then navigator if not in localstorage Co-authored-by: atrovato <1839717+atrovato@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)front/src/config/demo.json
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!