Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with new notification style #9

Closed
ajmeese7 opened this issue Sep 7, 2019 · 5 comments
Closed

Issue with new notification style #9

ajmeese7 opened this issue Sep 7, 2019 · 5 comments

Comments

@ajmeese7
Copy link
Contributor

ajmeese7 commented Sep 7, 2019

Before the notifications would get pretty wide to show my message in a clean manner, like this:

old

But now they only get so wide then stop, leaving the messages extremely unattractive:

new

I don't know what changed and I have been unable to pinpoint the issue myself, so I'm going to stick with using my unsupported hacky method until this is resolved. I can upload my entire old CSS if that will help you, but I'm leaving tomorrow so I won't be able to be much help fixing it.

@Glagan
Copy link
Owner

Glagan commented Sep 7, 2019

This might be related to some things I changed in the CSS file to allow animations that goes outside the notification wrapper, I will look at it.

@Glagan Glagan closed this as completed Sep 7, 2019
@Glagan Glagan reopened this Sep 7, 2019
@Glagan
Copy link
Owner

Glagan commented Sep 7, 2019

The issue only appears on mobile, it's fine on large screens
image

The problem is that the wrapper doesn't have enough space since i'm using %
image

@ajmeese7
Copy link
Contributor Author

ajmeese7 commented Sep 7, 2019

Is there a way you could fix that with media queries or something?

@Glagan
Copy link
Owner

Glagan commented Sep 7, 2019

This fix it but not really, I'm using the whole screen and set the position of the notifications with flex but if there is too much of them they stack up in the wrong direction, I realized it while I pushed.

Glagan added a commit that referenced this issue Sep 7, 2019
@Glagan Glagan closed this as completed Sep 7, 2019
@ajmeese7
Copy link
Contributor Author

Just got back to the real world so I'll try out these new commits soon and get you some feedback. Thanks for trying to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants