Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JESD3 lexer calculates wrong checksum whenever CR newlines are used #367

Closed
whitequark opened this issue Jul 29, 2023 · 1 comment · Fixed by #450
Closed

JESD3 lexer calculates wrong checksum whenever CR newlines are used #367

whitequark opened this issue Jul 29, 2023 · 1 comment · Fixed by #450
Labels
software Component: software

Comments

@whitequark
Copy link
Member

See whitequark/prjbureau#12 (prjbureau uses a copy of the Glasgow JESD3 code).
@whitequark whitequark added the software Component: software label Jul 29, 2023
@whitequark
Copy link
Member Author

Testcase: https://github.com/whitequark/prjbureau/files/11973074/testcase.jed.txt

whitequark added a commit to whitequark/glasgow that referenced this issue Oct 21, 2023
@whitequark
protocol.jesd3: require bytes input, to ensure checksum computes co…
de9dd9d 
…rrectly.

Fixes GlasgowEmbedded#367.
@whitequark whitequark mentioned this issue Oct 21, 2023
Merged
whitequark added a commit to whitequark/glasgow that referenced this issue Oct 21, 2023
@whitequark
protocol.jesd3: require bytes input, to ensure checksum computes co…
e59205a 
…rrectly.

Fixes GlasgowEmbedded#367.
@whitequark whitequark changed the title JESD3 lexer calculates wrong checksum on Windows JESD3 lexer calculates wrong checksum whenever CR newlines are used Oct 21, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 21, 2023
@whitequark
protocol.jesd3: require bytes input, to ensure checksum computes co…
b9547af 
…rrectly.

Fixes #367.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
software Component: software
Projects
None yet
Milestone
No milestone
1 participant
@whitequark