Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a flag to glasgow factory which indicates that the device has been modified from the original design #406

Closed
whitequark opened this issue Oct 2, 2023 · 0 comments · Fixed by #457
Closed

Add a flag to glasgow factory which indicates that the device has been modified from the original design #406

whitequark opened this issue Oct 2, 2023 · 0 comments · Fixed by #457
Assignees
@whitequark
Labels
feature-request Meta: feature request

Comments

@whitequark
Copy link
Member

Now that we have the strict policy outlined in the docs we might as well add mechanic means of ensuring compliance--in particular adding a log message.

Unresolved questions:

  • Should this be a WARN or an INFO message? Seeing a WARN every time you use the device can result in alert fatigue, so probably INFO.
@whitequark whitequark added the feature-request Meta: feature request label Oct 2, 2023
@whitequark whitequark self-assigned this Oct 21, 2023
@whitequark whitequark mentioned this issue Oct 21, 2023
Merged
whitequark added a commit to whitequark/glasgow that referenced this issue Oct 21, 2023
@whitequark
device.hardware: print a notice at INFO level for modified devices.
0bd473b 
Fixes GlasgowEmbedded#406.
whitequark added a commit to whitequark/glasgow that referenced this issue Oct 21, 2023
@whitequark
device.hardware: print a notice at INFO level for modified devices.
5786c04 
Fixes GlasgowEmbedded#406.
whitequark added a commit to whitequark/glasgow that referenced this issue Oct 21, 2023
@whitequark
device.hardware: print a notice at INFO level for modified devices.
f1e02b3 
Fixes GlasgowEmbedded#406.
github-merge-queue bot pushed a commit that referenced this issue Oct 23, 2023
@whitequark @attie
device.hardware: print a notice at INFO level for modified devices.
2b3da32 
Fixes #406.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whitequark whitequark

Labels
feature-request Meta: feature request
Projects
Maintenance
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a "built from modified design files" marker to firmware and software whitequark/glasgow
1 participant
@whitequark