Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract test code from each applet to a separate test.py file #447

Closed
whitequark opened this issue Oct 20, 2023 · 1 comment · Fixed by #448
Closed

Extract test code from each applet to a separate test.py file #447

whitequark opened this issue Oct 20, 2023 · 1 comment · Fixed by #448
Labels
applet Component: applet help-wanted Meta: help wanted

Comments

@whitequark
Copy link
Member

While the "one file per applet" paradigm was nice for a while, we have outgrown it, and the new directory structure reflects that already. Having tests in the main applet file breaks test discovery with just about any Python test framework. We should have tests in the glasgow/applet/<category>/<name>/test.py, next to glasgow/applet/<category>/<name>/__init__.py which contains the applet itself.
@whitequark whitequark added applet Component: applet help-wanted Meta: help wanted labels Oct 20, 2023
@whitequark
Copy link
Member Author

Note that this will need some additional work to unbreak glasgow test, which I will do once the mechanical part of this issue (the conversion to multi-file structure) is done.

wanda-phi added a commit to wanda-phi/glasgow that referenced this issue Oct 20, 2023
@wanda-phi
applet: extract test code to a separate file.
8bfa707 
Fixes GlasgowEmbedded#447.
@wanda-phi wanda-phi mentioned this issue Oct 20, 2023
Merged
wanda-phi added a commit to wanda-phi/glasgow that referenced this issue Oct 21, 2023
@wanda-phi
applet: extract test code to a separate file.
abbe227 
Fixes GlasgowEmbedded#447.
github-merge-queue bot pushed a commit that referenced this issue Oct 21, 2023
@wanda-phi @whitequark
applet: extract test code to a separate file.
03504f4 
Fixes #447.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
applet Component: applet help-wanted Meta: help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

applet: extract test code to a separate file. wanda-phi/glasgow
1 participant
@whitequark