firmware: switch the DAC off too when switching off Vio #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will update this once #242 is merged. |
esden
force-pushed
the
wip-dac-off-firmware
branch
from
ca49533
to
ebb09b4
Compare
|
@electroniceel #242 is merged, could you take a look please? |
Without this, the DAC still outputs it's control voltage even if Vio is off. This goes through the feedback resistors to the output. I measured about 15 mV without this patch on a port that was previously enabled. With this patch it properly goes down to zero. While such a low voltage usually shouldn't be a problem, I consider it unclean design, especially if it is so easy to fix.
whitequark
force-pushed
the
wip-dac-off-firmware
branch
from
ebb09b4
to
54b07b7
Compare
whitequark
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the DAC still outputs it's control voltage even if Vio is off.
This goes through the feedback resistors to the output. I measured about
15 mV without this patch on a port that was previously enabled.
With this patch it properly goes down to zero.
While such a low voltage usually shouldn't be a problem, I consider it
unclean design, especially if it is so easy to fix.
I based this off the wip-revC2-firmware branch to avoid a merge conflict with the firmware ihex.
All firmware changes also have to contain the binary firmware.
So this is intended to be merged after wip-revC2-firmware was merged.