Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add platform, architecture, and OS version to --version output #440

Merged
merged 1 commit into from
Oct 10, 2023
Merged

cli: add platform, architecture, and OS version to --version output #440

merged 1 commit into from
Oct 10, 2023

Conversation

whitequark
Copy link
Member

Fixes #400.

Output looks like this:

$ pdm run glasgow --version
Glasgow 0.1.dev1826+g4fe4acc.d20231004164618 (CPython 3.9.18 on Linux-6.1.0-10-amd64-x86_64-with-glibc2.37)

$ pdm run glasgow --version
Glasgow 0.1.dev1825+gcc2acdc (CPython 3.11.2 on Linux-6.1.0-10-amd64-x86_64-with-glibc2.36 Debian GNU/Linux 12 (bookworm))

% pdm run glasgow --version
Glasgow 0.1.dev1889+gb95a16e (CPython 3.11.5 on macOS-13.4.1-arm64-arm-64bit)

>pdm run glasgow --version
Glasgow 0.1.dev1891+g3833fcb (CPython 3.11.4 on Windows-10-10.0.19045-SP0)

@whitequark whitequark requested a review from attie October 9, 2023 07:11
attie
attie approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@attie attie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion to support py3.9, otherwise looks fine to me, thanks!

software/glasgow/cli.py Show resolved Hide resolved
@attie attie added this pull request to the merge queue Oct 10, 2023
Merged via the queue into GlasgowEmbedded:main with commit f3e3be3 Oct 10, 2023
10 of 11 checks passed
@emaste
Copy link

emaste commented Oct 12, 2023

For reference, on FreeBSD: Glasgow 0.1.dev1829+g54edef0.d20231004192744 (CPython 3.9.18 on FreeBSD-14.0-CURRENT-amd64-64bit-ELF)

@whitequark whitequark deleted the version-os-name branch October 12, 2023 18:16
@whitequark
Copy link
Member Author

@emaste Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attie attie attie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add host OS version to --version output
3 participants
@whitequark @emaste @attie