CI: fix semantics of the required check
#464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a dependency of the `required` check, e.g. `test-software` fails, the `required` check as a whole is considered skipped. While this works as expected for gating PR merges, it does not work the same way in the merge queue: in the latter case, the non-successful status does not prevent the merge queue branch from being merged to `main`. To address this, apply a workaround such that the `required` check always runs and programmatically checks the status of the required jobs rather than delegating this to GHA flow graph.
whitequark
force-pushed
the
fix-gha-required-check
branch
from
70488cf
to
d2924d1
Compare
Merged
via the queue into
GlasgowEmbedded:main
with commit Oct 23, 2023
6c59f4b
16 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a dependency of the
requiredcheck, e.g.test-softwarefails, therequiredcheck as a whole is considered skipped. While this works as expected for gating PR merges, it does not work the same way in the merge queue: in the latter case, the non-successful status does not prevent the merge queue branch from being merged tomain.To address this, apply a workaround such that the
requiredcheck always runs and programmatically checks the status of the required jobs rather than delegating this to GHA flow graph.Fixes #462.