Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual: develop/firmware: write the page #465

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

whitequark
Copy link
Member

@whitequark whitequark commented Oct 23, 2023

@whitequark whitequark force-pushed the manual-develop/firmware branch 5 times, most recently from a184aff to 3ee0d15 Compare October 24, 2023 00:05
@whitequark whitequark marked this pull request as draft October 24, 2023 06:25
@whitequark whitequark marked this pull request as ready for review October 24, 2023 10:41
@whitequark whitequark force-pushed the manual-develop/firmware branch 3 times, most recently from 797eb36 to 2a21057 Compare October 24, 2023 21:36
Copy link
Member

@attie attie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Only one very minor thought about the clarity of the "commit everything, then build, then commit ihex" process... but I think it's clear enough and protected by CI, so no need to change it.

@whitequark
Copy link
Member Author

Only one very minor thought about the clarity of the "commit everything, then build, then commit ihex" process...

It doesn't really have to be this way but it avoids extraneous diffs of the ihex file in the repository which keeps it a little bit smaller, and also makes bisecting easier. It's a soft requirement.

@whitequark whitequark added this pull request to the merge queue Oct 24, 2023
Merged via the queue into GlasgowEmbedded:main with commit 456113d Oct 24, 2023
16 of 20 checks passed
@whitequark whitequark deleted the manual-develop/firmware branch October 24, 2023 22:38
@attie
Copy link
Member

attie commented Oct 25, 2023

It's a soft requirement.

Oh, I thought it was a hard requirement because the binary includes the commit hash(?) ... can't be self referential, etc...

Fine either way.

@whitequark
Copy link
Member Author

Oh, I thought it was a hard requirement because the binary includes the commit hash(?) ... can't be self referential, etc...

What I mean is that the file being updated exclusively in the last commit is a soft requirement. Unless you update it separately at least in the last commit nothing would work, but besides that the CI doesn't really care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants