Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from appdirs to platformdirs #472

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

TobiX
Copy link
Contributor

@TobiX TobiX commented Oct 26, 2023

platformdirs is a friendly, maintained fork of appdirs (which stopped development after ~2020) - This should be 100% compatible for the used method.

I'm not exactly sure about the PDM lock file, getting rid of appdirs there might be dependent on YoWASP/runtime-py#2 ?!?

@whitequark
Copy link
Member

I'm not exactly sure about the PDM lock file, getting rid of appdirs there might be dependent on YoWASP/runtime#2 ?!?

You should be able to update the PR now that yowasp-runtime is released.

Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the PR slightly; now nothing in the dependency tree uses appdirs.

@whitequark
Copy link
Member

Thanks!

@whitequark whitequark added this pull request to the merge queue Oct 26, 2023
Merged via the queue into GlasgowEmbedded:main with commit 1efa4ea Oct 26, 2023
16 of 20 checks passed
@TobiX TobiX deleted the platformdirs branch October 26, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants