Add type annotations to all public methods in support.bits
#479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
... Oh, we can't do this until the lowest Python version we support is 3.11. |
whitequark
changed the title
support.bitssupport.bits
|
Or start depending on https://pypi.org/project/typing-extensions/. |
wanda-phi
reviewed
Oct 28, 2023
whitequark
force-pushed
the
bits-annot
branch
from
c2a1a7d
to
3ebb156
Compare
|
The |
whitequark
force-pushed
the
bits-annot
branch
from
3ebb156
to
0fa3257
Compare
The specific command
pdm lock -L pdm.min.lock -S direct_minimal_versions
needs to be run anytime dependencies are added or their versions are
changed, and it is not well known; add a shortcut for running it.
whitequark
force-pushed
the
bits-annot
branch
from
0fa3257
to
94a532e
Compare
whitequark
changed the title
support.bitssupport.bits
Merged
via the queue into
GlasgowEmbedded:main
with commit Oct 28, 2023
5a9b10f
18 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a policy change? Yes: I'm looking to gradually add typing annotations (specifically the Pylance dialect) to Glasgow, and then eventually to Amaranth.