applet.interface.jtag_pinout: Include --port in suggested arguments #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user has selected a non-default port spec, print it in the suggested command line, to ensure that the suggested pin numbers are correct.
neuschaefer
changed the title
whitequark
approved these changes
Jan 21, 2024
There was a problem hiding this comment.
Thanks!
For context for why this wasn't done before, I've avoided this in the past because of [idealistic concerns about API design that I don't want to bother writing down] but at this point I think the entire pin system needs to be scapped and rewritten so it doesn't matter.
Merged
via the queue into
GlasgowEmbedded:main
with commit Jan 21, 2024
8b360b1
18 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has selected a non-default port spec, print it in the suggested command line, to ensure that the suggested pin numbers are correct.