Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grammar "HTML (Handlebars)" and extension "handlebars" for language "Handlebars" #447

Closed
mikegleasonjr opened this issue Jul 6, 2015 · 3 comments
Closed

Add grammar "HTML (Handlebars)" and extension "handlebars" for language "Handlebars" #447

mikegleasonjr opened this issue Jul 6, 2015 · 3 comments
Assignees
@Glavin001
Labels
enhancement published quick-todo
Milestone
v0.29.0

Comments

@mikegleasonjr
Copy link
Contributor

Using Atom 1.0, atom-beautify 0.28.7
Language is set to HTML (Handlebars) for the file:

screen shot 2015-07-06 at 11 47 13 am
@Glavin001
Copy link
Owner

You will need to make a Pull Request adding HTML (Handlebars) grammar to the Atom Beautify language specifications: https://github.com/Glavin001/atom-beautify/blob/master/src/languages/handlebars.coffee#L11

Add extension to https://github.com/Glavin001/atom-beautify/blob/master/src/languages/handlebars.coffee#L18

Currently it only detects with the Handlebars grammar.

@Glavin001 Glavin001 added this to the v0.29.0 milestone Jul 6, 2015
@Glavin001 Glavin001 self-assigned this Jul 6, 2015
@Glavin001 Glavin001 changed the title Atom Beautify could not determine a supported beautifier to handle this file with grammar "HTML (Handlebars)" and extension "handlebars". Add grammar "HTML (Handlebars)" and extension "handlebars" for language "Handlebars" Jul 6, 2015
@mikegleasonjr
Copy link
Contributor Author

Thanks will do it later today :)

Glavin001 added a commit that referenced this issue Jul 7, 2015
@Glavin001
Merge pull request #450 from mikegleasonjr/handlebars-improvements
6939e58 
Closes #447. Improved Handlebars language support
@Glavin001
Copy link
Owner

Published to v0.28.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Glavin001 Glavin001

Labels
enhancement published quick-todo
Projects
None yet
Milestone
v0.29.0
Development

No branches or pull requests
2 participants
@mikegleasonjr @Glavin001