Fixes #1728. Remove Shell-Env from Executable, use Atom's process.env instead #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead Atom has builtin a fix for the process.env being out of sync with the user's actual environment variables. It is similar to how Shell-Env works which Atom-Beautify was using. Now we no longer need it. However, there is still an issue when running specs. Thus, Atom-Beautify specs still patch process.env with Shell-Env. See https://discuss.atom.io/t/specs-do-not-load-shell-environment-variables-activationhooks-core-loaded-shell-environment/44199 for details.
5 tasks
|
Published to v0.30.3 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Atom has builtin a fix for the process.env being out of sync with
the user's actual environment variables. It is similar to how Shell-Env works
which Atom-Beautify was using. Now we no longer need it.
However, there is still an issue when running specs. Thus, Atom-Beautify
specs still patch process.env with Shell-Env.
See https://discuss.atom.io/t/specs-do-not-load-shell-environment-variables-activationhooks-core-loaded-shell-environment/44199
for details.
Does this close any currently open issues?
#1728
Any other comments?
...
Checklist
Check all those that are applicable and complete.
masterbranchnpm run docsCHANGELOG.mdunder "Next" section