Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment parameters module port #52

Merged
merged 3 commits into from
Apr 15, 2021
Merged

Environment parameters module port #52

merged 3 commits into from
Apr 15, 2021

Conversation

EM-Creations
Copy link
Member

When merged this pull request will:

  • Port the environment parameters module to the new format.

@EM-Creations EM-Creations added the enhancement New feature or request label Apr 8, 2021
PiZZAD0X
PiZZAD0X reviewed Apr 8, 2021
View reviewed changes
Copy link
Member

@PiZZAD0X PiZZAD0X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice idea with the timelimit addition, just needs the private _var changes and should be good to go

@EM-Creations
Copy link
Member Author

very nice idea with the timelimit addition, just needs the private _var changes and should be good to go

I can't take credit for it sadly, this originally came from an unmerged PR to the original Olsen Framework and I had incorporated it into mine.

@EM-Creations EM-Creations merged commit bdeb381 into dev Apr 15, 2021
@EM-Creations EM-Creations deleted the feature/Env-parameters-port branch April 15, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiZZAD0X PiZZAD0X PiZZAD0X approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EM-Creations @PiZZAD0X