use ARMCI not MA mem in GA_Transpose #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GA_Transpose uses ga_malloc, which defaults to using MA memory. this means that GA requires MA to be initialized. this changes GA_Transpose to use ARMCI memory. if ARMCI_Malloc_local is much slower than ga_malloc, this might be noticeable (because the block is called in the loop) but that seems unlikely at this point. it is trivial to revert to the old implementation by undefining the macro (GA_TRANSPOSE_USE_ARMCI_MEM) that enables this. fix issue GlobalArrays#163 Signed-off-by: Jeff Hammond <jeff.science@gmail.com>
|
If there are no objections, I'd like to merge this. It is a very local change. |
|
Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GA_Transpose uses ga_malloc, which defaults to using MA memory. this means that GA requires MA to be initialized. this changes GA_Transpose to use ARMCI memory.
if ARMCI_Malloc_local is much slower than ga_malloc, this might be noticeable (because the block is called in the loop) but that seems unlikely at this point.
it is trivial to revert to the old implementation by undefining the macro (GA_TRANSPOSE_USE_ARMCI_MEM) that enables this.
fix issue #163
Signed-off-by: Jeff Hammond jeff.science@gmail.com