Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for more recent releases of Node.js #117

Closed
wants to merge 1 commit into from

Conversation

amotl
Copy link

@amotl amotl commented Nov 13, 2020

Hi there,

this adds compatibility for Node.js >11.15, see #101, #102 and #109.

With kind regards,
Andreas.

Build instructions

When using Node.js >11.15, these commands might work already.

# Install dependencies.
npx yarn install

# Run build.
npx yarn build

When Yarn is not installed (YMMV), this command might help:

# Install yarn globally.
npm install yarn -g

@daldoyle
Copy link
Contributor

Hi there,

Thanks very much for this PR and apologies for the big delay in getting back to you. We've been internally swapping over various repos to using "yarn" instead, and we ended up semi using this PR as the basis for that. I'm going to close this out and merge in the other one since it finalizes some other changes as well but wanted to make sure I left a note here saying thanks for the ideas.

@daldoyle daldoyle closed this Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants