Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加显存 / 内存问题帮助文档 & 读取日志算法优化 & 允许拖拽崩溃报告 #113

Merged
merged 13 commits into from
Aug 15, 2023

Conversation

youzi-2333
Copy link
Contributor

No description provided.

Copy link
Member

@bingxin666 bingxin666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议请专业人士来看

@bingxin666 bingxin666 requested review from bingxin666 and removed request for bingxin666 August 13, 2023 15:55
Copy link
Member

@HRxiaohu HRxiaohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

坏消息,有个大佬把分析器重写了,所以这个 PR.可能会直接关掉。

@bingxin666
Copy link
Member

坏消息,有个大佬把分析器重写了,所以这个 PR.可能会直接关掉。

草,绷不住了

@zyxkad
Copy link
Member

zyxkad commented Aug 14, 2023

坏消息,有个大佬把分析器重写了,所以这个 PR.可能会直接关掉。

git可以merge的

@youzi-2333
Copy link
Contributor Author

youzi-2333 commented Aug 14, 2023

坏消息,有个大佬把分析器重写了,所以这个 PR.可能会直接关掉。

……你说的是 #114 是吧,我这个其实也可以 Merge 一下(到时候我把冲突修掉)……………………………………………………………………

Edit:冲突修好了, 8d46b11 ………………

@bingxin666 bingxin666 removed their request for review August 14, 2023 11:04
@Seayay Seayay removed their request for review August 14, 2023 14:03
@Seayay
Copy link
Contributor

Seayay commented Aug 14, 2023

这种有技术性的 PR 我不会看,建议找 @Big-Cake-jpg @HRxiaohu

Copy link
Member

@bingxin666 bingxin666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这pr丢一天了没人看.jpg

@youzi-2333 youzi-2333 changed the title 完善原版客户端崩溃 & 分析算法优化 添加显存 / 内存问题帮助文档 & 读取日志算法优化 & 允许拖拽崩溃报告 Aug 15, 2023
@Pigeon0v0 Pigeon0v0 removed the request for review from XieXiLin2 August 15, 2023 00:40
@Pigeon0v0 Pigeon0v0 merged commit 7072c48 into GlobeMC:main Aug 15, 2023
2 checks passed
}

// 动画
function handleDragOver(e) {
analyzerBackgroundColor.value = "rgba(255,255,255,0.5)"
e.preventDefault() // 阻止浏览器默认拖拽行为
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请看下面@dragover.prevent, 后缀.prevent代表会自动调用preventDefault, 这里再调用就重复了

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

youzi-2333 added a commit to youzi-2333/crashmc.com that referenced this pull request Aug 15, 2023
Big-Cake-jpg pushed a commit that referenced this pull request Aug 18, 2023
* 添加行末空行

* 手动恢复 #113 核心修改;添加日志输出

* 再次更新日志分析算法

* 允许自动分析 Forge 缺少的前置 Mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants