Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

将错误分析器大部分代码用vue格式重写 #114

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Conversation

zyxkad
Copy link
Member

@zyxkad zyxkad commented Aug 13, 2023

原作者的代码真的惨不忍睹,都react时代了还在用传统document操作(

@zyxkad zyxkad marked this pull request as draft August 13, 2023 22:33
Copy link
Contributor

@Big-Cake-jpg Big-Cake-jpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请使用 pnpm 作为包管理器,否则多个 lockfile 可能会导致一些问题。

@zyxkad zyxkad marked this pull request as ready for review August 14, 2023 01:38
Copy link
Contributor

@Big-Cake-jpg Big-Cake-jpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你可以同时使用 vue router 重写跳转部分吗?

@HRxiaohu
Copy link
Member

确实,因为我是写 .Net 被临时拉过来的

@zyxkad
Copy link
Member Author

zyxkad commented Aug 14, 2023

你可以同时使用 vue router 重写跳转部分吗?

忘记了(

@zyxkad zyxkad marked this pull request as draft August 14, 2023 03:12
@zyxkad zyxkad marked this pull request as ready for review August 14, 2023 03:12
@zyxkad
Copy link
Member Author

zyxkad commented Aug 14, 2023

你可以同时使用 vue router 重写跳转部分吗?

嗯不对,他这个跳转是可以跳转到站外链接的,我打算之后直接用wasm重构错误扫描部分,所以就不费力气判断链接了(

@Seayay Seayay merged commit 0b67aca into GlobeMC:main Aug 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants