Update Hausa locale information #512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $hau->lang_code_iso_639_1 = 'ha'; | ||
| $hau->lang_code_iso_639_2 = 'hau'; | ||
| $hau->lang_code_iso_639_3 = 'hau'; | ||
| $hau->slug = 'hau'; |
There was a problem hiding this comment.
Any particular reason for the slug change?
There was a problem hiding this comment.
We're using ISO 639-3 codes for new WordPress locales and where possible adapting old ones as well (https://make.wordpress.org/polyglots/handbook/translating/requesting-a-new-locale/#find-your-language-code). Hausa has existed in GlotPress for a while but it doesn't have a WP locale and didn't have a site. The ISO 639-3 code is applied to the slugs as well as the language code for consistency. The site is already created with the slug hau.
|
@petyaraykovska Instead of updating the existing locale, let's add |
As per @ocean90's request, adding a new locale for Hausa in Latin script and bringing back the data for the old rtl locale. As per a GTE request & information on Ethnologue and Wikipedia, also fixing the Kirghiz locale code (former ky, which is the wrong code for the language) and exchanging the locale codes with the ISO 639-3 code.
| - $ha->slug = 'ha'; | ||
| - $ha->text_direction = 'rtl'; | ||
| - $ha->google_code = 'ha'; | ||
| - $ha->facebook_locale = 'ha_NG'; |
|
Please create one PR per locale. |
This was referenced Sep 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request: https://make.wordpress.org/polyglots/2016/04/22/request-for-adding-hausa-locale/