Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to allow not setting translations as fuzzy when importing similar originals #629

Closed
yoavf opened this issue Jan 1, 2017 · 2 comments
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@yoavf
Copy link
Member

yoavf commented Jan 1, 2017

When importing slightly changed originals, GP will mask existing translations as fuzzy.

In some cases, it might be a better outcome to keep the existing translations as is. For example, if only the context changed (the context is part of the string when comparing originals), or when the change is only in punctuation or case.

@yoavf yoavf self-assigned this Jan 1, 2017
yoavf added a commit to yoavf/GlotPress-WP that referenced this issue Jan 1, 2017
@yoavf yoavf changed the title Add filter to allow setting translations as fuzzy when importing similar originals Add filter to allow not setting translations as fuzzy when importing similar originals Jan 1, 2017
@tobifjellner
Copy link
Contributor

Copy/paste of my comment to #630
Hmm. I'm not sure this is the best way forward. This kind of changes (capitalization, interpunctuation, etc.) may sometimes have implications on the presentation level. Say, all items in a list do stop with a full stop, except one item. When this is fixed by the plugin/theme author, the clear intention is to have this propagated to the translated versions, too.

A better approach would be for fuzzy matches to record the original source string, and highlight the changes in the review view, thus speeding up the editorial work when walking through fuzzy matches.

If, for instance, the only difference in a long string is that two occurrences of http were changed to https, then such differential highlighting would allow me to be sure that there are no further changes I need to find and correct.

@yoavf
Copy link
Member Author

yoavf commented Jan 1, 2017

Hmm. I'm not sure this is the best way forward. This kind of changes (capitalization, interpunctuation, etc.) may sometimes have implications on the presentation level. Say, all items in a list do stop with a full stop, except one item. When this is fixed by the plugin/theme author, the clear intention is to have this propagated to the translated versions, too.

The default is still to mark translations as fuzzy. This proposed solution allows GlotPress plugins the flexibility to set exceptions (based on any number of parameters), and I don't think there's anything bad in that.

A better approach would be for fuzzy matches to record the original source string, and highlight the changes in the review view, thus speeding up the editorial work when walking through fuzzy matches.

I agree, but that's another path forward, which doesn't necessarily contradicts this one.

@ocean90 ocean90 added [Type] Enhancement A suggestion for improvement. [Status] In Progress Tracking issues with work in progress labels Jan 10, 2017
@ocean90 ocean90 added this to the 2.3 milestone Jan 10, 2017
yoavf added a commit to Automattic/GlotPress-WP that referenced this issue Jan 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants