Multi-check functionality only works forward and not backwards

[garretthyder]

Hello,

The multi-select function of checkboxes only works going down the page and not back up. By the multi-select function I speak on when you check a checkbox and then skip a few rows and check another checkbox then all checkboxes in between become checked. The code for this;
https://github.com/GlotPress/GlotPress-WP/blob/43bb5383e114835b09fc47c727d06e6d3ca8114e/assets/js/translations-page.js#L47-L68

This only works from top to bottom, it would be nice if it worked in reverse as well so if you check a box low in the page and then go up and check another then all boxes in between get checked.

How it functions going down the page;

Going in reverse this illustrates how it doesn't check the boxes in between;

Hope that makes sense,
Cheers

[toolstack]

Seems like an easy fix, just add the following after first/last are calculated:

if( first > last ) { swap = last; last = first; first = swap; }

Of course there is the note above that the code was taken from WP, so perhaps it's already been fixed there?

[toolstack]

Just took a look, they have fixed it in WP:

			if ( 0 < first && 0 < last && first != last ) {
				sliced = ( last > first ) ? checks.slice( first, last ) : checks.slice( last, first );
				sliced.prop( 'checked', function() {
					if ( $(this).closest('tr').is(':visible') )
						return checked;

					return false;
				});
			}