Don't set context to empty string by default #1726
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR solves the bug introduced here, as this bug sets the context property to empty string if the value is NULL.
Fixes #1724.
Solution
The solution is to remove one check that sets the property
context
to empty string if its value is NULL, and to check if the context property is a string before using with themb_strlen
function as its paremeter, to avoid introducing the previous bug (warning) another time.Testing Instructions
I have made 2 manual tests with the same steps: