237: Remove the thing's magic method. #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocean90
changed the title
The _no_map magic method is only valid for a few methods in the class, but is callable via __call() on all methods. This change removes the __call() magic method and adds the required [func]_no_map() methods to the class. It also replaces a single instance of value_no_map() with value() as _no_map has no effect on the value() function. This makes the code more readable, solve solves several scrutinizer issues and allows for better doc blocks.
ocean90
force-pushed
the
237-remove-thing-magic-methods
branch
from
047d739
to
289e192
Compare
ocean90
added a commit
that referenced
this pull request
Feb 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _no_map magic method is only valid for a few methods in the class, but is callable via __call() on all methods. This change removes the __call() magic method and adds the required [func]_no_map() methods to the class.
It also replaces a single instance of value_no_map() with value() as _no_map has no effect on the value() function.
This makes the code more readable, solve solves several scrutinizer issues and allows for better doc blocks.
Part of #237.