Boss bars for Wither & Ender Dragon #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramperes
reviewed
Dec 25, 2017
| if (hurtSound != null && !isSilent()) { | ||
| world.playSound(location, hurtSound, getSoundVolume(), getSoundPitch()); | ||
| } | ||
| Sound hurtSound = health > 0 ? getHurtSound() : getDeathSound(); |
There was a problem hiding this comment.
What is the reason for this change? Death sound is already played here:
aramperes
reviewed
Dec 25, 2017
| public void setHealth(double health) { | ||
| super.setHealth(health); | ||
| if (health <= 0) { | ||
| bar.removeAll(); |
There was a problem hiding this comment.
I think this should be moved to the remove() method instead. It is called when the entity dies, as well as if it is removed by other factors like despawning or plugins.
aramperes
approved these changes
Dec 26, 2017
kamcio96
approved these changes
Dec 27, 2017
|
I'm fine with merging this for this release because it isn't huge and doesn't have breaking changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #641 first. Should this wait for after 2018.0.0?