-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing Java 9 support! (Fixes #576) #649
Conversation
smartboyathome
commented
Dec 29, 2017
•
edited
Loading
edited
- Glowstone has a new GlowBootstrap main() method, in charge of downloading any depndencies before starting the application.
- GlowMain now contains the contents of the old GlowServer.main() method.
- LibraryManager was rewritten to use the Jar Class Loader library, rather than relying on URLClassLoader.addURL().
- Still works on Java 8!
- Glowstone has a new GlowBootstrap main() method, in charge of downloading any depndencies before starting the application. - GlowMain now contains the contents of the old GlowServer.main() method. - LibraryManager was rewritten to use the Jar Class Loader library, rather than relying on URLClassLoader.addURL().
NB: Until projectlombok/lombok#985 can at least be worked around, we'll still have to build on JDK 8 and can't do a multirelease jar. |
Hey, I yesterday also tried to figure out a fix for this problem. So that looks quiet good |
Good note. It's true that it won't build on Java 9, but I was more focused on getting it to run. The key to this was minimizing the classes referenced in the bootstrap phase. That's one reason I created GlowMain and reference it only as a runnable, trying hard to avoid triggering any static variables from being loaded. |
I test this pull-request on my server and it did not work!
So the mysql driver is not loaded! --- EDITED --- This Problem occurs under Java 8 too.
|
This reverts commit 3f96747.
I have reverted it. @smartboyathome please remake the PR. |
@hibo98 I cannot reproduce this. I ran it on my Win10 machine and it starts up just fine, both under Java 8 and Java 9. What OS are you using? Any specific configuration I should be aware of? |
Like you I am using Windows 10, with installed Oracle Java 8 or 9. And the start up also fine. |
Thanks. I'll play around some tonight, but https://stackoverflow.com/questions/42052856/java-9-classpath-and-library-path-extension worries me, seems like plugins that rely on JDBC just may not work with how Glowstone downloads its libraries anymore. |