[WIP] implement getters/setter in GlowPlayerProfile #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my relatively primitive attempt to implement the remaining getters/setters in GlowPlayerProfile that are currently unsupported.
While this seems pretty basic I think it should have a similar enough behavior to other implementations, since I don't think others resolve input id's during set/construction either.
Since there's not an internal object used to hold the owner here, I had to remove the
finalfrom the name. You may also may want to decide if it should bevolatilenow that it can be changed by different threads.This is not ready for merging without changes after review.
Let me know.