Furnace #189
Merged
Furnace #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase on top of master or pull from Glowkit so that you get the merged changes from Glowkit. |
|
I've rebased, and I think it is better if you update Glowkit commit in GlowstonePlusPlus |
|
Oh, hm, I thought I had updated Glowkit on master, sorry about that mistake! |
- Return bucket when lava bucket is used as fuel - Only allow fuels to be placed in the fuel slot (and buckets too) - Place on shiftclicking: fuels into fuel slot, smeltables into input slot and else using normal - DroppableCraftingSlot not for furnace and brewing inventory
- For the moment dont allow AIR at Result slot (I need here an other solution) - Right handeling for Result slots in Furnace Inventory - Firstly check for furnace recipe then for fuel - Added missing furnace recipes for LOG and LOG_2
- Use event outputs - Fill bucket with water when dry sponge
|
Thank you for your contribution! |
picknchew
pushed a commit
to picknchew/Glowstone
that referenced
this pull request
Sep 2, 2016
mastercoms
added a commit
that referenced
this pull request
Feb 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of furnace
TODO:
Should be done in an other PR:
(I think with the current WindowClickHandler this isn't possible, because FurnaceExtractEvent is BlockXpEvent)
For this PR Glowkit#11 and Glowkit#13 is needed