Adds FallingBlock and Bug fix #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds FallingBlock
|
It appears I didn't push everything |
|
#243 This has the complete and correct pull |
picknchew
pushed a commit
to picknchew/Glowstone
that referenced
this pull request
Sep 2, 2016
This is a mix of GlowstoneMC#242 and GlowstoneMC#130. Thanks to @coasterman10 and @BeYkeRYkt for their work! This commit adds block sounds with a pitch deviation of +/- 0.25. It changes the default value for the sound to stone, unless the block uses the default blocktype. In that case, it uses the wood sound. Some of the block sounds are not set correctly, especially 1.8 stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds FallingBlock.
Fixes bug with flower pot not dropping items.
Known Bugs with FallingBlock.
For some reason BlockFalling.onNearBlockChanged() is being called twice instead of once causing to falling blocks to spawn for every one.
Red sand to be sand when falling. This is because I currently don't know how to add data to falling blocks.