Merged
Conversation
Pr0methean
requested changes
Nov 13, 2018
|
|
||
| @Before | ||
| public void setupMocks() { | ||
| // cache the event factory |
Contributor
There was a problem hiding this comment.
I'm pretty sure some of this is redundant to the superclass's @Before method.
Contributor
Author
There was a problem hiding this comment.
Thank you for pointing that out. I tried to use the serverShim but was unable to, it mocks World and the test I wrote needs GlowWorld.
I have removed the unused superclass.
Pr0methean
approved these changes
Nov 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix builds on the earlier work by Pr0methean [fb5cc7b]. The issue was that
UseItemHandlerrestored the original item into the inventory. I guess this was done in order to delete items when they are consumed.I made a similar fix to
BlockPlacementHandler.