-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert load_urls to a Stream #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The downloading should work as a stream, everything from picking the URL from the file through the download from the Internet to the local drive file write should happen separately for every item, not by repeated enumeration over a list. This required another version of the download/3 function accepting a Stream and returning a Stream.
I now think that the |
Merged
The aforementioned is addressed in #67. |
This was referenced Feb 13, 2022
nappex
approved these changes
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The downloading should work as a stream, everything from picking the URL from the file through the download from the Internet to the local drive file write should happen separately for every item, not by repeated enumeration over a list.
This required another version of theStarted with converting thedownload/3
function accepting aStream
and returning aStream
.load_urls/1
function to aStream
.