Remove download_urls/3 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enumerable traversal is a trivial concept. It does not make sense to have a separate function just to do Enum.map. It brings confusing function dichotomy and a need for guard clauses. Also it discourages from using other types of enumerables like streams. For the function to be testable, the get_env call needed to be moved to main/0, which makes nice symmetry with http_client. Because the input_path parameter is of the same type and thus indistiguishable from a URL, it only makes sense to rename the function.
|
Extracted the |
Glutexo
force-pushed
the
remove-download-urls
branch
from
4bba653
to
1db8469
Compare
Reverted the get_env move to minimize the amount of changes. Used Enum.map in the malfunctioning “download URLs from the input file” test to at least make it still download all the URLs.
Glutexo
force-pushed
the
remove-download-urls
branch
from
1db8469
to
8895fef
Compare
|
Reverted the |
|
Merged current elixir and resolved conflicts. |
|
May become better after #70 is resolved. |
nappex
approved these changes
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #66 (comment), enumerable traversal is a trivial concept. It does not make sense to have a separate function just to do
Enum.map. It brings confusing function dichotomy and a need for guard clauses. Also it discourages from using other types of enumerables like streams.For the function to be testable, the
get_envcall needed to be moved tomain/0, which makes nice symmetry withhttp_client. Because theinput_pathparameter is of the same type and thus indistinguishable from a URL, it only makes sense to rename the function.