Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(admin-ui): improvements required in webhook shortcode #1624

Closed
duttarnab opened this issue Mar 14, 2024 · 0 comments · Fixed by #1625
Closed

fix(admin-ui): improvements required in webhook shortcode #1624

duttarnab opened this issue Mar 14, 2024 · 0 comments · Fixed by #1625
Assignees
@duttarnab
Labels
bug Something isn't working comp-admin-ui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality

Comments

@duttarnab
Copy link
Contributor

duttarnab commented Mar 14, 2024 •
edited

TODOs

  1. Change short code from {code} to ${code} so that it can be identified and replaced by value by java backend
  2. Often the placement of short-code is not proper in request-body
  3. Short code button gets hidden for long request-body.
@duttarnab duttarnab added bug Something isn't working comp-admin-ui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Mar 14, 2024
@duttarnab duttarnab self-assigned this Mar 14, 2024
@duttarnab duttarnab changed the title fix(admin-ui): improvements in webhook shortcode fix(admin-ui): improvements required in webhook shortcode Mar 14, 2024
duttarnab added a commit that referenced this issue Mar 14, 2024
@duttarnab
fix: improvements required in webhook shortcode #1624
73e6239 
Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>
@duttarnab duttarnab mentioned this issue Mar 14, 2024
Merged
duttarnab added a commit that referenced this issue Mar 18, 2024
@duttarnab
Merge pull request #1625 from GluuFederation/admin-ui-issue-1624
03e81fe 
fix: improvements required in webhook shortcode #1624
jv18creator pushed a commit that referenced this issue Mar 18, 2024
@duttarnab @jv18creator
fix: improvements required in webhook shortcode #1624
0694748 
Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>
@jv18creator jv18creator mentioned this issue Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duttarnab duttarnab

Labels
bug Something isn't working comp-admin-ui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improvements required in webhook shortcode #1624 GluuFederation/flex
1 participant
@duttarnab