feat: added standardjs custom tweaks standardx and fix no-unused-expr…

…ession problem

.eslintrc.json

@@ -1,35 +1,10 @@
 {
-    "env": {
-        "node": true,
-        "commonjs": true,
-        "mocha" : true,
-        "es6" : true
-
-    },
-    "extends": "eslint:recommended",
-    "parserOptions": {
-        "ecmaVersion": 11
-    },
+    "env": { "mocha": true },
+    "plugins": [
+        "chai-friendly"
+    ],
     "rules": {
-        "indent": [
-            "error",
-            "tab"
-        ],
-        "linebreak-style": [
-            "error",
-            "unix"
-        ],
-        "quotes": [
-            "error",
-            "single"
-        ],
-        "semi": [
-            "error",
-            "never"
-        ],
-        "max-len": [
-            "warn",
-            { "code" : 80 }
-        ]
+        "no-unused-expressions": 0,
+        "chai-friendly/no-unused-expressions": 2
     }
-}
+}

package.json

@@ -13,7 +13,7 @@
     "start": "NODE_ENV=production node server/app.js",
     "test": "NODE_ENV=test cucumber-js --exit test/features && NODE_ENV=test nyc mocha --exit --no-warnings test/*.test.js",
     "dev": "NODE_ENV=development node server/app.js",
-    "lint": "standard",
+    "lint": "standardx",
     "generate-coverage": "NODE_ENV=test nyc report --reporter=text-lcov > coverage.lcov",
     "report-2": "NODE_ENV=test nyc mocha --report lcovonly -R spec && codecov"
   },
@@ -70,14 +70,15 @@
     "chai-http": "^4.3.0",
     "codecov": "^3.7.1",
     "cucumber": "^6.0.5",
+    "eslint-plugin-chai-friendly": "^0.6.0",
     "got": "^11.6.0",
     "husky": "^4.3.0",
     "mocha": "^8.1.1",
     "nock": "^13.0.2",
     "nyc": "^15.1.0",
     "rewire": "^5.0.0",
     "sinon": "^9.0.2",
-    "standard": "^14.3.4",
+    "standardx": "^5.0.0",
     "supertest": "^4.0.2"
   },
   "repository": {
@@ -90,18 +91,6 @@
     "url": "https://github.com/GluuFederation/gluu-passport/issues"
   },
   "homepage": "https://github.com/GluuFederation/gluu-passport#readme",
-  "standard": {
-    "globals": [
-      "describe",
-      "context",
-      "before",
-      "beforeEach",
-      "after",
-      "afterEach",
-      "it",
-      "expect"
-    ]
-  },
   "husky": {
     "hooks": {
       "pre-commit": "npm run lint"

test/app.init.test.js

@@ -199,12 +199,10 @@ describe('app.init() - Initialization', () => {
     })
 
     it('expect spTLSCert file to exist', () => {
-      // eslint-disable-next-line no-unused-expressions
       expect(file(response.body.conf.spTLSCert)).to.exist
     })
 
     it('expect spTLSKey file to exist', () => {
-      // eslint-disable-next-line no-unused-expressions
       expect(file(response.body.conf.spTLSKey)).to.exist
     })
   })