Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's impossible to remove entries from "Logout URI" property of OIDC client. #366

Closed
aliaksander-samuseu opened this issue Oct 5, 2016 · 12 comments
Assignees
Labels
exclude from release notes issues found during QA that should be excluded from release notes
Milestone

Comments

@aliaksander-samuseu
Copy link
Contributor

aliaksander-samuseu commented Oct 5, 2016

Environment:
CentOS 6.7, Gluu CE 2.4.4 SP2, Firefox 49.0.2

Steps to reproduce:

  1. Log in to web UI as admin
  2. Move to "OpenID -> Client" page
  3. Create some basic client registration of type "Web" providing minimal set of required settings; make sure to set "Logout session required" to "True"; add some [bogus] uri as logout uri (by clicking "Add Logout URI" button); click "Update" button
  4. Try to remove "Logout URI" you added before by clicking little cross button to the right of it

Result:
User is redirected to home page and "System error" message appears. Java exception is registered to wrapper.log ( here is full text of it ):

INFO   | jvm 1    | 2016/10/05 17:10:36 | Oct 05, 2016 5:10:36 PM com.sun.faces.lifecycle.InvokeApplicationPhase execute
INFO   | jvm 1    | 2016/10/05 17:10:36 | WARNING: #{_clientAction.removeNewLogoutURI(_uri)}: javax.el.MethodNotFoundException: //localhost/identity/WEB-INF/incl/client/clientForm.xhtml @391,235 action="#{_clientAction.removeNewLogoutURI(_uri)}": Method not found: org.gluu.oxtrust.action.UpdateClientAction@7b9fbcf4.removeNewLogoutURI(java.lang.String)
INFO   | jvm 1    | 2016/10/05 17:10:36 | javax.faces.FacesException: #{_clientAction.removeNewLogoutURI(_uri)}: javax.el.MethodNotFoundException: //localhost/identity/WEB-INF/incl/client/clientForm.xhtml @391,235 action="#{_clientAction.removeNewLogoutURI(_uri)}": Method not found: org.gluu.oxtrust.action.UpdateClientAction@7b9fbcf4.removeNewLogoutURI(java.lang.String)
INFO   | jvm 1    | 2016/10/05 17:10:36 |   at com.sun.faces.application.ActionListenerImpl.processAction(ActionListenerImpl.java:109)
INFO   | jvm 1    | 2016/10/05 17:10:36 |   at javax.faces.component.UICommand.broadcast(UICommand.java:315)
@shekhar16
Copy link
Collaborator

image

@shekhar16
Copy link
Collaborator

image

@shekhar16
Copy link
Collaborator

Hi @aliaksander-samuseu
It is working on ce-dev and my local env.
I m not able to reproduce it please let me know if i missed something.

@aliaksander-samuseu
Copy link
Contributor Author

aliaksander-samuseu commented Nov 5, 2016

@shekhar16

Not sure why/in which package you can't reproduce it. Still is easily triggered in CentOS6.7 Gluu CE 2.4.4 + SP2 (see attached picture). I also think fix for this one should too be a candidate to be pushed into SP2 for 2.4.4 packages.

selection_047

Update:
You can trigger it even without creating a test client first. It will happen even if this uri is added during its initial creation, then right away this cross button is clicked to remove it.

@shekhar16
Copy link
Collaborator

shekhar16 commented Nov 6, 2016

Sorry @aliaksander-samuseu I tested again in my local with latest code and on ce-dev env aswel i.e. https://ce-dev.gluu.org/identity and found it is working fine.please try on https://ce-dev.gluu.org/identity env.
On which env you are testing?

@aliaksander-samuseu
Copy link
Contributor Author

@shekhar16

I'm testing in my own local instance. You can see environment described at the start of the report

@nynymike
Copy link
Contributor

@aliaksander-samuseu can you re-test and close this issue if you can't replicate?

@shekhar16
Copy link
Collaborator

@aliaksander-samuseu @nynymike
the issue is fixed in below issue
#321
And @aliaksander-samuseu yes this issue exist in sp2 version but Please confirm fixes included in sp2 version.
@nynymike I think sp2 involves only specific functionalities and fixes, it doesn't contains latest code present at build time.

@shekhar16 shekhar16 removed their assignment Dec 5, 2016
@yurem
Copy link
Contributor

yurem commented Dec 28, 2016

Now remove buttons calls right method

@yurem yurem closed this as completed Dec 28, 2016
@aliaksander-samuseu
Copy link
Contributor Author

aliaksander-samuseu commented Jan 18, 2017

Reopening.
It works fine in 3.0.x CE, but I still can't confirm it works in latest 2.4.4.2 packages available in repos. Tested for gluu-server-2.4.4.2_6-1~trusty+Ub14.04_amd64.deb of 2016-11-07 (which is the latest available stable package), and the issue is still there. Shouldn't it be already fixed in SP2? If it wasn't added to it, then it should be candidate for SP3.

@mzico
Copy link
Contributor

mzico commented Jan 26, 2017

@aliaksander-samuseu : It's working in 2.4.4.2 ( ** ) version. Please validate.

(**)

GLUU.root@idp:~# cat /opt/tomcat/webapps/oxauth/META-INF/MANIFEST.MF
Manifest-Version: 1.0
Implementation-Title: oxAuth Server
Implementation-Version: 2.4.4.sp3
Implementation-Vendor-Id: org.xdi
Built-By: tomcat
Build-Jdk: 1.7.0_79
Created-By: Apache Maven 3.3.9
Implementation-Build: a4faf1c8915c628e5d3826cbf7bb5923f9dd3eea
Archiver-Version: Plexus Archiver

GLUU.root@idp:~# cat /opt/tomcat/webapps/identity/META-INF/MANIFEST.MF
Manifest-Version: 1.0
Implementation-Title: oxTrust Server
Implementation-Version: 2.4.4.sp2
Implementation-Vendor-Id: org.xdi
Built-By: tomcat
Build-Jdk: 1.7.0_79
Created-By: Apache Maven 3.3.9
Implementation-Build: bcdae
Archiver-Version: Plexus Archiver

GLUU.root@idp:~#

@mzico mzico added exclude from release notes issues found during QA that should be excluded from release notes and removed bug labels Jan 26, 2017
shekhar16 pushed a commit that referenced this issue Jan 26, 2017
@shekhar16
Copy link
Collaborator

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from release notes issues found during QA that should be excluded from release notes
Projects
None yet
Development

No branches or pull requests

5 participants