New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Add Person form user is not able to navigate to next input field by pressing the [Tab] button in keyboard #907

Closed
wasiqulhuq opened this Issue Mar 18, 2018 · 9 comments

Comments

Projects
None yet
5 participants
@wasiqulhuq

wasiqulhuq commented Mar 18, 2018

Perform following steps to reproduce,

  1. Go to Add Person form
  2. Click on Username input field and enter username
  3. Press on [Tab] button in keyboard and observe that user is not navigated to the next input field in the form which is First Name field.

When user click on tab button in they expect to navigate to the next field in the form. In user self registration form in Gluu user is able to move between input fields by hitting the tab button which is expected.

Check below screen for detail information,

tab

@wasiqulhuq wasiqulhuq added this to the 3.1.3 milestone Mar 18, 2018

@wasiqulhuq wasiqulhuq changed the title from In Add Person form user is not able to navigate to next input field by hitting the tab button in keyboard to In Add Person form user is not able to navigate to next input field by pressing the [Tab] button in keyboard Mar 18, 2018

@shekhar16

This comment has been minimized.

Contributor

shekhar16 commented Mar 19, 2018

we fixed it in latest code commit on #861

@shekhar16 shekhar16 closed this Mar 19, 2018

@willow9886

This comment has been minimized.

Contributor

willow9886 commented Apr 24, 2018

@shekhar16 tabs now work... but the new field you tab into is not selected...so the user still has to click from field to field!

@willow9886 willow9886 reopened this Apr 24, 2018

@shekhar16

This comment has been minimized.

Contributor

shekhar16 commented Apr 25, 2018

The fields has been implemented with <rich:inplaceInput , so for every field we had span and input fields in combine form that's why, on focus its only focusing the field but not allowing to enter text.

@yurem

This comment has been minimized.

Contributor

yurem commented Apr 27, 2018

In next version we are planning to remove richfaces at all. I think we can replace rich:inplaceInput with h:inputText to make text input generic across all our GUI.

@yurem yurem modified the milestones: 3.1.3, 3.1.4 Apr 30, 2018

shekhar16 added a commit that referenced this issue May 4, 2018

@shekhar16

This comment has been minimized.

Contributor

shekhar16 commented May 4, 2018

image

@shekhar16

This comment has been minimized.

Contributor

shekhar16 commented May 4, 2018

Tabs are working to edit the textbox.

yurem added a commit that referenced this issue May 16, 2018

@shekhar16 shekhar16 closed this Jul 3, 2018

@natt-tester

This comment has been minimized.

natt-tester commented Aug 14, 2018

@shekhar16, I've just tested it and there seems to be quite a lot of buggy behavior present. Did you check the functionality after finishing the task?

Whenever I click on a field or use a tab, an error message pops out. Even as a reminder, it looks pretty aggressive, so without any real update/addition we shouldn't display them.

Also, the show/hide password icon doesn't seem to work.

And it's impossible to add a new user:

no_user

There's a typo, the string should be "Uid already exists".

The whole activity throws the following error:

error2

Refer to the GIF:
buggybug

@natt-tester natt-tester reopened this Aug 14, 2018

@shekhar16

This comment has been minimized.

Contributor

shekhar16 commented Aug 15, 2018

@natt-tester

  1. The primary validations are working on losing the focus on fields i.e if you leave the field blank and change focus from that fields it will validate immediately that's why u are seeing validation message popup.I think u should know about onfocus validations.

  2. Show/hide buttons are not working because we are working on richfaces => primfaces migration i.e. #768. And show/hide button already fixed in that branch, as this issue still in progress for other pages so we can't merged it right now.

  3. We fixed the duplicate uid validation in 7fc02f4

@yurem i consolidated above changes in new PR (i.e. #1100 ) for above pending changes.So that u can merge it.

@natt-tester

This comment has been minimized.

natt-tester commented Aug 15, 2018

@shekhar16, great that there are some fixes provided. I always report what I see as a user, and at the moment of testing, the UX was terrible. "You know it works like that" doesn't really apply if we want to make the UX better.

I would suggest getting rid of the popup messages on focus out soon as possible, especially when the user clicks through them. The behavior in this view is inconsistent with other menu items' behavior, e.g. in Register Attribute. The way I see it, if there's any button that could validate the whole form -- just like Register does in this view -- it should do it, highlighting the field and/or providing a meaningful hint in/under the field + a pop-up:

validation

@shekhar16 shekhar16 closed this Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment