some fixes to python example scripts for python3 compatibility #415
Conversation
| @@ -126,7 +126,7 @@ def period_end(start_year, start_month, period_type): | |||
| # so we get a period end like | |||
| # 2010-03-31 for period starting 2010-01 instead of 2010-04-01 | |||
| return date(end_year, end_month, 1) - ONE_DAY | |||
|
|
|||
|
|
|||
| def generate_period_boundaries(start_year, start_month, period_type, periods): | |||
| for i in xrange(periods): | |||
There was a problem hiding this comment.
Shouldn't xrange be changed to range?
There was a problem hiding this comment.
Good point. I'm sure there are some more things like this.
thanks to Sumit Bhardwaj for the hint
|
I've created a bug report as a collection for remaining issues in the transition from python 2 to python 3. |
|
Do you want to keep working on this PR until Friday (when I start putting the release together) or make a new one for more changes? |
|
Let's keep this one till friday. |
|
Well, that Friday came and went along with the release of 3.3, so this missed it. I've merged now to keep that from happening again. You'll just have to make a new PR when you get around to working on this again. Thanks. |
|
Thanks. I was busy with some other projects but will pick this up again the coming weeks. Good to be reminded. |
|
Until the next release things about python3 should be fixed (that's my goal). I saw this PR as part of that and didn't feel a need to hurry. |
No description provided.