Skip to content

Commit

Permalink
Request RoomStateRevisionIssuers in order for protected rooms.
Browse files Browse the repository at this point in the history
We believe this is the cause of a performance regression in Draupnir:
the-draupnir-project/Draupnir#380.
Unfortunately we don't have the infrastructure in our unit testing
or deployment to be able to truthfully understand the cause.

So we have created a follow up the-draupnir-project/Draupnir#389.
Our approach for now is just to guess some of the most glaring
changes that have caused the regression.

If this fails to make a significant difference, other culprits
are changes to the parsing code (ie, there was a recent version
of MPS where we moved away from accidentally using the empty
schema for most event content), including the recent upgrade
to typebox 0.32.22.
  • Loading branch information
Gnuxie committed May 4, 2024
1 parent e03b154 commit e57f266
Showing 1 changed file with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,11 @@ export class StandardProtectedRoomsManager
SetMembershipMirror.addRoom(blankSetMembership, room, membershipIssuer);
}
);
const allProtectedRooms = protectedRoomsConfig.getProtectedRooms();
const results = await Promise.all(allProtectedRooms.map(joinAndAdd));
const error = results.find(isError);
if (error !== undefined) {
return error;
for (const room of protectedRoomsConfig.getProtectedRooms()) {
const result = await joinAndAdd(room);
if (isError(result)) {
return result;
}
}
return Ok(
new StandardProtectedRoomsManager(
Expand Down

0 comments on commit e57f266

Please sign in to comment.