Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set nsec to null by default in crypto_aead_aes256gcm.go #9

Closed
neuegram opened this issue Nov 3, 2015 · 1 comment
Closed

Set nsec to null by default in crypto_aead_aes256gcm.go #9

neuegram opened this issue Nov 3, 2015 · 1 comment

Comments

@neuegram
Copy link
Contributor

neuegram commented Nov 3, 2015

According to the libsodium documentation, "nsec is not used by this particular construction and should always be NULL." Since this is the case, I think we should handle this in our code. Less of an issue, more of a to-do.
@redragonx
Copy link
Contributor

I agree with this change.

silkeh added a commit to silkeh/libsodium-go that referenced this issue Mar 20, 2017
@silkeh
Add, test and fix CryptoAEADAES256GCM functions
ff1d7ef 
- Fix CryptoAEADAES256GCMNSecBytes()
- Remove nsec from CryptoAEADAES256GCMEncrypt() and Decrypt()
- Add support.CheckSizeMin for things with a minimum size
- Add support.BytePointer to get a pointer for things than can have 0 length
- Add CryptoAEADAES256GCMIsAvailable(), CryptoAEADAES256GCMEncryptDetached(),
  CryptoAEADAES256GCMDecryptDetached() and CryptoAEADAES256GCMKeyGen()
- Add tests for all encryption and decryption functions (related to GoKillers#1)

Closes GoKillers#9
silkeh added a commit to silkeh/libsodium-go that referenced this issue Apr 29, 2017
@silkeh
Add and fix CryptoAEADAES256GCM functions
046821e 
- Fix CryptoAEADAES256GCMNSecBytes()
- Remove nsec from CryptoAEADAES256GCMEncrypt() and Decrypt()
- Add support.CheckSizeMin for things with a minimum size
- Add support.BytePointer to get a pointer for things than can have 0 length
- Add CryptoAEADAES256GCMIsAvailable(), CryptoAEADAES256GCMEncryptDetached(),
  CryptoAEADAES256GCMDecryptDetached() and CryptoAEADAES256GCMKeyGen()

Closes GoKillers#9
silkeh added a commit to silkeh/libsodium-go that referenced this issue Apr 29, 2017
@silkeh
Add and fix CryptoAEADAES256GCM functions
2179f68 
- Fix CryptoAEADAES256GCMNSecBytes()
- Remove nsec from CryptoAEADAES256GCMEncrypt() and Decrypt()
- Add support.CheckSizeMin for things with a minimum size
- Add support.BytePointer to get a pointer for things than can have 0 length
- Add CryptoAEADAES256GCMIsAvailable(), CryptoAEADAES256GCMEncryptDetached(),
  CryptoAEADAES256GCMDecryptDetached() and CryptoAEADAES256GCMKeyGen()

Closes GoKillers#9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neuegram @redragonx