[GING-306] Pin Poetry version to 1.4.2 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like 1.5.0 has broken deployments in the properties service. 1.4.2 was the last working version in our CI logs. Hopefully this will fix the deployments until we can work out why 1.5.0 breaks with the properties service.
lelemi1031
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like 1.5.0 (released 4 days ago) has broken deployments in the properties service. 1.4.2 was the last working version in our CI logs. Hopefully this will fix the deployments until we can work out why 1.5.0 breaks with the properties service.
Favourites service deployed fine with 1.5.0. https://github.com/GoProperly/favourite-listings/actions/runs/5062324583/jobs/9087704198
This is the issue I found in properties service, although closed with nothing helpful added: python-poetry/poetry-plugin-export#112
Description
(briefly describe what this pull request does)
For Reviewers
(add any notes for reviewers)