Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player should support window scaling #101

Closed
civic9 opened this issue Apr 21, 2019 · 4 comments · Fixed by #208
Closed

Player should support window scaling #101

civic9 opened this issue Apr 21, 2019 · 4 comments · Fixed by #208
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@civic9
Copy link

civic9 commented Apr 21, 2019

Hi, Some suggestions for the player.

  1. Replay window scaling would be very helpful.
  2. notify2 is totally incompatible with ms-windows, I think. I use the player with import notify2 and its calls commented out (but otherwise it works well, thanks). done in Added Windows support #129
@civic9 civic9 changed the title player enhancement player enhancements Apr 21, 2019
@Res260
Copy link
Collaborator

Res260 commented Apr 21, 2019

What kind of error do you get with notify2? We have not tested the app for Windows, so your feedback is appreciated! :)

@civic9
Copy link
Author

civic9 commented Apr 21, 2019

notify2 uses dbus which I don't think has any chance to work in windows.
https://stackoverflow.com/questions/49972005/no-module-named-dbus-error

Package dbus-python can't be installed on windows, so I removed it from setup.py.
Then notify2 can't work without dbus module:

Traceback (most recent call last):
  File "bin\pyrdp-player.py", line 23, in <module>
    from pyrdp.logging import LOGGER_NAMES, NotifyHandler
  File "c:\tmp\pyrdp\pyrdp\logging\__init__.py", line 10, in <module>
    from pyrdp.logging.handlers import NotifyHandler
  File "c:\tmp\pyrdp\pyrdp\logging\handlers.py", line 5, in <module>
    import notify2
  File "c:\users\civic9\AppData\Local\Programs\Python\Python36\lib\site-packages\
notify2.py", line 39, in <module>
    import dbus
ModuleNotFoundError: No module named 'dbus'

I think notifications could be just disabled for windows. It is not critical feature :)

@obilodeau
Copy link
Member

Windows support, which was recently released, gets rid of notify2.

I'll adjust this issue so that it focuses only on window scaling.

@obilodeau obilodeau changed the title player enhancements Player should support window scaling Oct 3, 2019
@obilodeau obilodeau added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 3, 2019
@alxbl
Copy link
Collaborator

alxbl commented Apr 2, 2020

If anyone decides to look at this:

For window scaling, this could be implemented directly in the QRemoteDesktop (pyrdp/ui/qt.py) widget by polling the dimensions of the parent window and calling scaled() on the QImage buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants