Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows isn't supported #127

Closed
Pourliver opened this issue Jul 3, 2019 · 5 comments
Closed

Windows isn't supported #127

Pourliver opened this issue Jul 3, 2019 · 5 comments
Assignees

Comments

@Pourliver
Copy link
Contributor

From what I've seen, there are two things which block PyRDP from running on Windows.

  1. Notify2 uses dbus, which doesn't exist on Windows, as reffered in Player should support window scaling #101. This is fixed in my branch windows_support
  2. pycrypto doesn't work out of the box on Windows. It require some manual modification to pycrypto itself. Pycrypto isn't supported anymore, the replacement is pycryptodome.

We could (and probably should) replace pycrypto by pycryptodome. If anyone has tried to use PyRDP on Windows, I'd like to know if there's anything I'm missing.

@Res260
Copy link
Collaborator

Res260 commented Jul 3, 2019

Note that PyCrypto is used for the RC4 encryption (when TLS is not used), so keep that in mind when testing!

@obilodeau
Copy link
Member

If it's only used for RC4 and nothing else (no HMAC, etc.) then we should probably inline an open version. It's simple

@Res260
Copy link
Collaborator

Res260 commented Jul 3, 2019

@xshill would be the reference for that.

@Pourliver
Copy link
Contributor Author

From my test, the RC4 encryption works the same in pycrypto and pycryptodome. The only part that changed was the RSA module. So handling RC4 isn't a problem. But I will still be testing the changes over RDP and TLS security :)

@Res260
Copy link
Collaborator

Res260 commented Aug 31, 2019

Implemented in #129

@Res260 Res260 closed this as completed Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants