Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert pyrdp recordings to mp4/mkv #170

Closed
OXERY opened this issue Nov 28, 2019 · 2 comments · Fixed by #199
Closed

Convert pyrdp recordings to mp4/mkv #170

OXERY opened this issue Nov 28, 2019 · 2 comments · Fixed by #199
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@OXERY
Copy link

OXERY commented Nov 28, 2019

Hi there,
did anybody manage to export the pyrdp-recordings as video files?

@Res260
Copy link
Collaborator

Res260 commented Nov 28, 2019

It has not been done, as far as I know. We used a screen recorder when we needed it. It would be a nice addition to PyRDP!

@obilodeau obilodeau added enhancement New feature or request help wanted Extra attention is needed labels Feb 6, 2020
@alxbl
Copy link
Collaborator

alxbl commented Mar 24, 2020

Here are my thoughts on this:

We could repurpose the pyrdp-pcap-converter tool to be just pyrdp-convert which would support all our format conversions:

  • pcap to replay
  • replay to mp4
  • pcap to mp4 (via replay)

I'm planning to use PyAV since it appears to provide most of the bindings that we need in libavcodec.
We would eventually depend on libavcodec anyway if we want to support the other video pipelines. For now the dependency would be optional when pyrdp-convert is used.

This is the next significant feature I intend to work on unless something else comes up.

Cheers,
Alex

@alxbl alxbl mentioned this issue Mar 24, 2020
4 tasks
@alxbl alxbl added this to the vNext milestone Mar 24, 2020
@alxbl alxbl removed the help wanted Extra attention is needed label Apr 8, 2020
@alxbl alxbl self-assigned this Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants