Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyRDP Pcap Extractor #188

Closed
wants to merge 7 commits into from
Closed

Add PyRDP Pcap Extractor #188

wants to merge 7 commits into from

Conversation

obilodeau
Copy link
Member

This has been in a branch aside for a while now since it was not very polished. However, it is valuable so I think we should aim to introduce it to master soon.

TODO

  • move Warning from README to the tool itself
  • rename the tool. Suggestion: pyrdp-pcap-extractor
  • feature: extract transferred files (or files dragged and dropped)
  • test with a pcap in GDI passthrough mode and make sure that we can extract all interesting virtual channels (keyboard, files, etc.)

@obilodeau obilodeau added the enhancement New feature or request label Mar 10, 2020
@Res260
Copy link
Collaborator

Res260 commented Mar 18, 2020

doesnt pyrdp-pcap-extractor suggest that PyRDP can somehow extract pcaps? pyrdp-replay-extractor seems more suitable

@alxbl alxbl added this to the vNext milestone Mar 24, 2020
@alxbl
Copy link
Collaborator

alxbl commented Mar 24, 2020

I'm thinking this could be merged with the mp4 conversion issue (#170) and renamed to pyrdp-convert to be the global tool for converting. Thoughts?

@Res260 Res260 mentioned this pull request Mar 25, 2020
14 tasks
@alxbl
Copy link
Collaborator

alxbl commented Apr 2, 2020

I would vote to close this in favor of #199 which contains the refactored pyrdp-convert as discussed. Let me know.

@alxbl
Copy link
Collaborator

alxbl commented Apr 6, 2020

Closing as superseded by #199

@alxbl alxbl closed this Apr 6, 2020
@obilodeau obilodeau deleted the pyrdp-replay-rebase branch May 25, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants