Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hash as name for intercepted files #261

Closed
xshill opened this issue Nov 13, 2020 · 0 comments
Closed

Use hash as name for intercepted files #261

xshill opened this issue Nov 13, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request waiting-merge A fix for this exists but hasn't been merged yet
Milestone

Comments

@xshill
Copy link
Collaborator

xshill commented Nov 13, 2020

It would be better if PyRDP used an intercepted file's hash instead of a random name when saving them to disk. Even though we already detect duplicate files using hashes and store the original file name in the mapping.json file, using hashes directly on the filesystem would make it easier for external tools to detect duplicates (e.g: if you're backing up intercepted files) because then they wouldn't have to parse the mapping file.

@xshill xshill self-assigned this Nov 13, 2020
@xshill xshill added the enhancement New feature or request label Nov 13, 2020
@xshill xshill added the waiting-merge A fix for this exists but hasn't been merged yet label Nov 25, 2020
@xshill xshill added this to the v1.1.0 milestone Nov 26, 2020
@xshill xshill mentioned this issue Dec 23, 2020
@xshill xshill closed this as completed Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request waiting-merge A fix for this exists but hasn't been merged yet
Projects
None yet
Development

No branches or pull requests

1 participant