-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added some logging of X224 negotiation failures #102
Conversation
Press F to pay respects to the forgotten PR 🙏 |
After an in-person review refresh with Emilio, I made all the requested changes. Please consider for merge again. May I suggest using a squash merge 😉 |
Will test then merge if nothing is on fire! |
Tested the changes, and added code to transfer the FailurePDU back to the client so the client can gracefully exit with a message saying that NLA is not supported on its computer (lol). Merging. |
WIP because I left a TODO task in there and forgot why.
Please review and enlighten me.