Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a connection time log statement upon client disconnection #112

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Add a connection time log statement upon client disconnection #112

merged 1 commit into from
Jun 10, 2019

Conversation

Res260
Copy link
Collaborator

@Res260 Res260 commented Jun 9, 2019

Implements #111

@Res260 Res260 requested review from Pourliver and xshill June 9, 2019 00:46
@xshill
Copy link
Collaborator

xshill commented Jun 9, 2019

The commit name and change are completely unrelated?

@Res260
Copy link
Collaborator Author

Res260 commented Jun 9, 2019

Damn I pushed the wrong thing, I'll fix that soon

@xshill
Copy link
Collaborator

xshill commented Jun 9, 2019

The changes seem right, it's just the message that's wrong.

@Res260
Copy link
Collaborator Author

Res260 commented Jun 9, 2019

I opened a separate PR for those changes

@Res260
Copy link
Collaborator Author

Res260 commented Jun 9, 2019 •
edited
Loading

Ok nevermind I simply got confused. Should be good now

@Res260 Res260 changed the title add generated cert and private key names to gitignore Add a connection time log statement upon client disconnection Jun 9, 2019
xshill
xshill reviewed Jun 9, 2019
View reviewed changes
Copy link
Collaborator

@xshill xshill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

Pourliver
Pourliver approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@Pourliver Pourliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Pourliver Pourliver merged commit cb6f495 into master Jun 10, 2019
@Pourliver Pourliver mentioned this pull request Jun 10, 2019
Closed
@obilodeau obilodeau deleted the add_connection_time branch November 27, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xshill xshill xshill left review comments

@Pourliver Pourliver Pourliver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Res260 @xshill @Pourliver